Refactor control to use ListView #125
Merged
+845
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugener
approved these changes
Mar 23, 2022
abhinayagarwal
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Full refactoring of the previous version.
It uses a ListView control, to lay out a TextFlow control per ListCell. This control will render a paragraph (that can have multiple decorations and pieces).
A paragraph list found from the pieceTable iterating over line feed characters.
Selection and caret work as expected.
There are minor issues to fix with the scrollbars and when resizing the ListView.
There are TODOs with some pending improvements for a next iteration (mainly related to paragraph features).