Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement currency formatting #351

Closed
wants to merge 28 commits into from
Closed

Implement currency formatting #351

wants to merge 28 commits into from

Conversation

rxaviers
Copy link
Member

  • Implementation
  • Tests
  • Doc

Fix #238

@ragulka ragulka mentioned this pull request Nov 28, 2014
Closed
1 task
@rxaviers
Copy link
Member Author

rxaviers commented Dec 1, 2014

Info about size...

globalize/currency is 2.6K minified and gzipped (96% the size of globalize/number), i.e., considerable size. Most of the bytes come from [:^S:] implementation, which is used to generate the formatter. But, not used to execute it.

This PR has minimal impact on other modules, adds 52 bytes on globalize (core), removes 32 bytes from globalize/date and removes 3 bytes from globalize/number.

@rxaviers
Copy link
Member Author

rxaviers commented Dec 2, 2014

This is ready for review.

@rxaviers rxaviers force-pushed the fix-238-currency branch 3 times, most recently from fdd4263 to e597b03 Compare December 2, 2014 14:27
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Create initial currency module
481a475 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Implement currency formatting (symbol mode)
e944ad0 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Implement currency formatting (name and code mode)
af7822b 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Use supplemental currency data
74c89ca 
The number of decimal places and the rounding for each currency is not
locale-specific. Those values are overridden by Supplemental Currency
Data.

Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Implement .formatCurrency()
32e2fb5 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Doc: Add currency formatting
ff02185 
- Add `.currencyFormatter( currency [, options] )`;
- Add `.formatCurrency( value, currency [, options] )`;

Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 2, 2014
@rxaviers
Currency: Implement currency formatting (accounting style)
e597b03 
Fixes #238
Closes #351
@rxaviers
Currency: Create initial currency module
3cd0afa 
Ref #238
Ref #351
@rxaviers
Currency: Implement currency formatting (symbol mode)
511e299 
Ref #238
Ref #351
@rxaviers
Currency: Implement currency formatting (name and code mode)
11ee323 
Ref #238
Ref #351
@rxaviers
Currency: Use supplemental currency data
c49d1fa 
The number of decimal places and the rounding for each currency is not
locale-specific. Those values are overridden by Supplemental Currency
Data.

Ref #238
Ref #351
@rxaviers
Currency: Implement .formatCurrency()
4252428 
Ref #238
Ref #351
@rxaviers
Doc: Add currency formatting
710d182 
- Add `.currencyFormatter( currency [, options] )`;
- Add `.formatCurrency( value, currency [, options] )`;

Ref #238
Ref #351
@rxaviers
Doc: Change plural example
7b7bb8d 
Amends "Plural: Create generator method".
Amends 3e1626e
Ref #335
Ref #336
@rxaviers
Currency: Implement currency formatting (accounting style)
9d98247 
Fixes #238
Closes #351
@rxaviers
Copy link
Member Author

rxaviers commented Dec 2, 2014

Open questions:

jzaefferer
jzaefferer reviewed Dec 3, 2014
View reviewed changes
doc/api/currency/currency-formatter.md
locales using the plural messages `Globalize( locale ).currencyFormatter( currency,
{ style: "name" } )( 1 )`.

| `USD` | `1.00 US dollar` | `1,00 US-Dollar` | `1.00美元` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like its missing the header line, like the previous one:

| 3-letter currency code | en (English) | de (German) | zh (Chinese) |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks, fixed.

@rxaviers
(fix) Doc: Add currency formatting
adb1ed6 
"This looks like its missing the header line, like the previous one"
@rxaviers
(fix) Doc: Add currency formatting
4ba83bd 
"This duplicates too much information from currency-formatter.md, should just
reference that"
@rxaviers
(fix) Doc: Add currency formatting
9f1c888 
Remove extra space.
jzaefferer
jzaefferer reviewed Dec 8, 2014
View reviewed changes
src/common/regexp-not-s.js
@@ -0,0 +1,13 @@
define(function() {

// Generated by:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining what this regex does would help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@rxaviers rxaviers mentioned this pull request Dec 9, 2014
Open
@rxaviers
Copy link
Member Author

rxaviers commented Dec 9, 2014

Updates made.

rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Create initial currency module
0453b62 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (symbol mode) (1/2)
4c050c6 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (name and code mode) (1/2)
0034b58 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Use supplemental currency data
d7dceef 
The number of decimal places and the rounding for each currency is not
locale-specific. Those values are overridden by Supplemental Currency
Data.

Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (accounting style)
5026636 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (symbol mode) (2/2)
4b89bbe 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (name and code mode) (2/2)
a094abf 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement .formatCurrency()
e84c593 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Doc: Add currency formatting
9dd27b8 
- Add `.currencyFormatter( currency [, options] )`;
- Add `.formatCurrency( value, currency [, options] )`;

Fixes #238
Closes #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Util: Object extend
b0f4443 
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Use supplemental currency data
33fd596 
The number of decimal places and the rounding for each currency is not
locale-specific. Those values are overridden by Supplemental Currency
Data.

Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (accounting style)
4e8fce0 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (symbol mode) (2/2)
0aadce3 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement currency formatting (name and code mode) (2/2)
a2f6865 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Currency: Implement .formatCurrency()
a267613 
Ref #238
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Doc: Add currency formatting
87e1f55 
- Add `.currencyFormatter( currency [, options] )`;
- Add `.formatCurrency( value, currency [, options] )`;

Fixes #238
Closes #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Util: Object extend
00819f3 
Ref #351
rxaviers added a commit that referenced this pull request Dec 10, 2014
@rxaviers
Util: Object extend
0dce9a5 
Ref #351
@rxaviers rxaviers closed this in bb3f7b3 Dec 10, 2014
@rxaviers rxaviers deleted the fix-238-currency branch December 10, 2014 15:06
@jzaefferer jzaefferer mentioned this pull request Dec 23, 2014
Closed
3 tasks
rxaviers added a commit to rxaviers/globalize that referenced this pull request Feb 15, 2015
@rxaviers
Currency: Minor accounting style fix
1895c8a 
Amends a2f6865
Ref globalizejs#238
Ref globalizejs#351
rxaviers added a commit that referenced this pull request Feb 15, 2015
@rxaviers
Currency: Minor accounting style fix
dcdc6bb 
Amends a2f6865
Ref #238
Ref #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting currencies
2 participants
@rxaviers @jzaefferer