Ensure protocolForUrl works in fastboot@3.1.0 environment
#1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
approved these changes
Sep 2, 2020
rwjblue
force-pushed
the
refactor-protocolForUrl
branch
from
ba9cdae to
2a802fb
Compare
`fastboot` creates a sandboxed VM context that has a `URL` global set to
the result of `require('url')`, and does **not** expose a global
`require` method at all (for security reasons).
That means that the changes made to `protocolForUrl` (which landed Ember
3.22.0-beta.2+) break the usage of `fastboot` with an error like the
following:
```
/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/vendor.js:58488
var nodeURL = _nodeModule.module.require('url');
^
TypeError: Cannot read property 'require' of null
at /var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/@glimmer/runtime.js:288:1
at internalRequire (/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/loader.js:54:1)
at internalRequire (/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/loader.js:50:1)
at internalRequire (/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/loader.js:50:1)
at internalRequire (/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/loader.js:50:1)
at require (/var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/loader.js:87:1)
at /var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/vendor.js:76572:1
at /var/folders/cx/h0pn1kjn4971gtp4_5mrm3940000gn/T/broccoli-70503kLAdbxQD1YdI/out-423-broccoli_merge_trees/assets/vendor.js:76573:2
at Script.runInContext (vm.js:127:20)
at VMSandbox.eval (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/vm-sandbox.js:14:16)
at /Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/ember-app.js:190:15
at Array.forEach (<anonymous>)
at EmberApp.loadAppFiles (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/ember-app.js:187:21)
at EmberApp.retrieveSandboxedApp (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/ember-app.js:235:10)
at new EmberApp (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/ember-app.js:61:21)
at FastBoot._buildEmberApp (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/index.js:114:17)
at new FastBoot (/Users/marcoow/Code/ember-simple-auth/node_modules/fastboot/src/index.js:52:10)
at /Users/marcoow/Code/ember-simple-auth/node_modules/ember-cli-fastboot/index.js:335:29
at Layer.handle [as handle_request] (/Users/marcoow/Code/ember-simple-auth/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/Users/marcoow/Code/ember-simple-auth/node_modules/express/lib/router/index.js:317:13)
at /Users/marcoow/Code/ember-simple-auth/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/Users/marcoow/Code/ember-simple-auth/node_modules/express/lib/router/index.js:335:12)
at next (/Users/marcoow/Code/ember-simple-auth/node_modules/express/lib/router/index.js:275:10)
at /Users/marcoow/Code/ember-simple-auth/node_modules/ember-cli/lib/tasks/server/middleware/broccoli-watcher/index.js:54:11
at watcher.then.errorHandler.buildError (/Users/marcoow/Code/ember-simple-auth/node_modules/broccoli-middleware/lib/watcher-middleware.js:35:7)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
```
---
This refactors things to leverages the native JS `URL` global (which is
available in all environments that we support **except** IE11).
rwjblue
force-pushed
the
refactor-protocolForUrl
branch
from
2a802fb to
95e16ff
Compare
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastbootcreates a sandboxed VM context that has aURLglobal set to the result ofrequire('url'), and does not expose a globalrequiremethod at all (for security reasons).That means that the changes made to
protocolForUrl(which landed Ember 3.22.0-beta.2+) break the usage offastbootwith an error like the following:This refactors things to leverages the native JS
URLglobal (which is available in all environments that we support except IE11).Fixes #1140