Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spec says an enum can be a null #32

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

jessfraz
Copy link
Contributor

This is a breaking change for anyone on older versions.

Relevant issue: github/rest-api-description#454

This is a breaking change for anyone on older versions.

Relevant issue: github/rest-api-description#454

Signed-off-by: Jess Frazelle <jess@oxide.computer>
@ahl
Copy link
Collaborator

ahl commented Aug 28, 2021

Took me a minute to get to this. Because I did some additional digging. OpenAPI 3.0.3 which is the germane version for this crate right now mostly leans on the JSON Schema Wright Draft 00 which confirms that enum values may be null: https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-5.20

@ahl ahl merged commit f6d7572 into glademiller:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants