Skip to content

On opening Editor right side panel show JS error #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shofiul-Alam opened this issue Jul 10, 2024 · 2 comments
Closed

On opening Editor right side panel show JS error #156

Shofiul-Alam opened this issue Jul 10, 2024 · 2 comments

Comments

@Shofiul-Alam
Copy link

When clicking save as to save current template with a different name following error is coming up.

image

Also I did not found any element input[data-v-filename]. I changed as follows in the builder.js file and it worked. Please do a review.

image
	document.querySelector("#save-offcanvas [data-v-filename]").innerHTML = filename;
	// document.querySelector("#save-offcanvas input[data-v-filename]").val(filename);
	document.querySelector("#save-offcanvas input[data-v-basename]").value = filename;
	document.querySelector("#save-offcanvas [data-v-theme-folders]").value = folder;
givanz added a commit that referenced this issue Jul 11, 2024
Fixed On opening Editor right side panel show JS error #156
Fixed clicking on save or Save As button keep loader spinning #157
@givanz
Copy link
Owner

givanz commented Jul 11, 2024

Thank you for the bug report, it's fixed in the last commit fa2d148

@Shofiul-Alam
Copy link
Author

@givanz Many many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants