Skip to content

Commit 605a70f

Browse files
committed
Added escape for menu items to avoid XSS for custom post types menu entries, vulnerability reported by @0xHamy
1 parent 84c11d6 commit 605a70f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

admin/template/content/menus/menu.tpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ if ($_categories) {
3434
$type = '@@__data-type__@@';
3535
if ($menu['type'] == $type) {
3636
$langtext = reset($menu['languages']);
37-
echo $langtext['name'] ?? '';
37+
echo htmlspecialchars($langtext['name'] ?? '');
3838
} else echo ' ';
3939
?>
4040

@@ -93,7 +93,7 @@ foreach ($languages as $key => $language) {
9393
[data-v-languages] input[data-v-language_id]|value = <?php echo $language_id;?>
9494
[data-v-languages] input[data-v-language_id]|name = <?php echo "menu_item_content[$language_id][language_id]";?>
9595
96-
@language [data-v-language-lang-name]|innerText = <?php echo ucfirst($language['name']);?>
96+
@language [data-v-language-lang-name]|innerText = <?php echo ucfirst(htmlspecialchars($language['name']));?>
9797
@language [data-v-language-*]|innerText = $menu['languages'][$language_id]['@@__data-v-language-(*)__@@']
9898
@language [data-v-language-*]|name = <?php echo "menu_item_content[$language_id][@@__data-v-language-(*)__@@]";?>
9999
@language input[data-v-language-*]|value = $menu['languages'][$language_id]['@@__data-v-language-(*)__@@']

0 commit comments

Comments
 (0)