Skip to content

Commit 84c11d6

Browse files
committed
Added escape for content slug and name fields to avoid XSS, vulnerability reported by @0xHamy
1 parent ab7b56a commit 84c11d6

File tree

1 file changed

+31
-9
lines changed

1 file changed

+31
-9
lines changed

admin/template/content/edit.tpl

+31-9
Original file line numberDiff line numberDiff line change
@@ -88,28 +88,50 @@ $_i++;
8888

8989
[data-v-{{type}}] input[data-v-{{type}}-content-*]|value = <?php
9090
$desc = '@@__data-v-{{type}}-content-(*)__@@';
91-
if (isset($content[$desc]))
92-
echo $content[$desc];
91+
if (isset($content[$desc])) {
92+
if ($desc == 'content') {
93+
echo $content[$desc];
94+
} else {
95+
echo htmlspecialchars($content[$desc]);
96+
}
97+
}
9398
?>
9499

95100
[data-v-{{type}}] [data-v-{{type}}-content-*]|innerText = <?php
96101
$desc = '@@__data-v-{{type}}-content-(*)__@@';
97-
if (isset($content[$desc]))
98-
echo $content[$desc];
102+
if (isset($content[$desc])) {
103+
if ($desc == 'content') {
104+
echo $content[$desc];
105+
} else {
106+
echo htmlspecialchars($content[$desc]);
107+
}
108+
}
99109
?>
100110

101111
[data-v-{{type}}] a[data-v-{{type}}-content-*]|href = <?php
102112
$desc = '@@__data-v-{{type}}-content-(*)__@@';
103-
if (isset($content[$desc]))
104-
echo $content[$desc];
113+
if (isset($content[$desc])) {
114+
if ($desc == 'content') {
115+
echo $content[$desc];
116+
} else {
117+
echo htmlspecialchars($content[$desc]);
118+
}
119+
}
105120
?>
106121

122+
107123
[data-v-{{type}}] textarea[data-v-{{type}}-content-*] = <?php
108124
$desc = '@@__data-v-{{type}}-content-(*)__@@';
109-
if (isset($content[$desc]))
110-
echo $content[$desc];
125+
if (isset($content[$desc])) {
126+
if ($desc == 'content') {
127+
echo $content[$desc];
128+
} else {
129+
echo htmlspecialchars($content[$desc]);
130+
}
131+
}
111132
?>
112133

134+
113135
[data-v-{{type}}] input[data-v-{{type}}-content-language_id]|value = <?php echo $language['language_id']; ?>
114136

115137

@@ -136,7 +158,7 @@ foreach ($revisions as $revision) {
136158
}
137159
?>
138160

139-
[data-v-{{type}}] [data-v-revisions_url]|href = $this->revisions_url
161+
[data-v-{{type}}] [data-v-revisions_url]|href = <?php echo $this->revisions_url . '&language_id=' . $language['language_id'];?>
140162

141163

142164
@site = [data-v-sites] [data-v-site]

0 commit comments

Comments
 (0)