-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make .bat and .cmd editors work on windows #1656
Conversation
@@ -23,6 +23,7 @@ | |||
// #![deny(clippy::expect_used)] | |||
//TODO: consider cleaning some up and allow specific places | |||
#![allow(clippy::significant_drop_tightening)] | |||
#![allow(clippy::multiple_crate_versions)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a red-flag. why do we want that? it bloats the binary. did you investigate what introduces the multiple versions of the same crate?
@@ -22,5 +22,6 @@ version = "1.0.3" | |||
multiple-versions = "deny" | |||
skip-tree = [ | |||
{ name = "windows-sys" }, | |||
{ name = "hermit-abi" } | |||
{ name = "hermit-abi" }, | |||
{ name = "syn" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
Multiple versions do not get built into the product, they only happen on test builds
Same for cargo deny I tried real hard to untangle the multiple versions even though it only really happens with tests. I could not untangle some of them (people who version their crate 0.xx are very annoying because 0.45 is not seen as a valid replacement for 0.44 by cargo. Yes windows-sys we are looking at you) Then I saw that you already had the ignore dups in main.rs and in deny.toml and decided OK its not just me that could not un ravel these TL;DR - the dups only happen when running tests |
I had to do a quick commit with that allow taken out because I could not remember what actually failed, I knew it was part of the CI build |
I just discovered squash. I apologize for my messy prs. I will clean this up |
This Pull Request fixes/closes #1316.
This has several parts
The actual fix is fairly straightforward.
cmd /C <editor> <file>
The reorg needs an explanation
I also note that there are no other external editor test cases. I will add more once I get this in (I willl look at #1654 and put them in the fix for that). I did add one generic test, but there should be more
I followed the checklist:
make check
without errors