Fix backtick mapping for macOS symbol layer #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mapped to the tilde (~), which is Shift + ` (backtick) on US-English QWERTY layouts; Alt + ` is actually a Mac dead key for inputting accents, so we'll map the backtick to itself.
iansan5653
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
This should definitely fix the immediate bug and I think it's the right change, but maybe to guard against future cases where these keys might overlap, we should consider only using this map if Alt is pressed. It would be pretty easy to update the logic where this is used (hotkey/src/hotkey.ts#50) to add this check:
- const nonOptionPlaneKey = matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : key
+ const nonOptionPlaneKey = hotkeyString.includes('Alt') && matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : keyThis would help prevent any future bugs in case an alt-key overlaps with a non-alt-key.
| @@ -16,7 +16,7 @@ export const macosSymbolLayerKeys: Record<string, string> = { | |||
| ['º']: '0', | |||
| ['–']: '-', | |||
| ['≠']: '=', | |||
| ['`']: '~', | |||
| ['`']: '`', | |||
There was a problem hiding this comment.
We should be able to just delete this line, since the default is to use the key itself:
Line 50 in bc70e3d
Suggested change
| ['`']: '`', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mapped to the tilde (~), which is Shift + Backtick on US-English QWERTY layouts; Alt + Backtick is actually a Mac dead key for inputting accents, so we'll map the backtick to itself.