Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace '--set-upstream origin' with --set-upstream-to #22621

Closed
wants to merge 2 commits into from

Conversation

dgdg-app
Copy link

@dgdg-app dgdg-app commented Dec 12, 2022

Why:

https://stackoverflow.com/a/18032014

What's being changed (if available, include any code snippets, screenshots, or gifs):

Git documentation states the call has been deprecated (for confusing syntax) in favor of --set-upstream-to which is self-descriptive and thus more suitable for examples in GitHub's documentation.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Dec 12, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/using-git/about-git.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@dgdg-app dgdg-app changed the title --set-upstream-to favored for simplicity replace '--set-upstream origin' with --set-upstream-to Dec 12, 2022
@cmwilson21
Copy link
Contributor

@dgdg-app Thank you for opening a PR and providing the link. Could you fill out the pull request template in the top comment in this pull request? Adding additional information to summarize the link will to help speed along the review process.

Thank you! 💖

@cmwilson21 cmwilson21 added the more-information-needed More information is needed to complete review label Dec 12, 2022
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 20, 2022
@cmwilson21
Copy link
Contributor

@dgdg-app Thanks for the additional context! I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review using git Content related to using git get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team stale There is no recent activity on this issue or pull request more-information-needed More information is needed to complete review labels Dec 21, 2022
@isaacmbrown
Copy link
Contributor

Hi @dgdg-app,

Thanks for contributing. ✨ I'm going to close this PR, because set-upstream-to is not an option for git push (see https://git-scm.com/docs/git-push). It has indeed been introduced, and set-upstream deprecated, but for the git branch command only (https://git-scm.com/docs/git-branch).

@isaacmbrown isaacmbrown closed this Jan 9, 2023
@isaacmbrown isaacmbrown removed the waiting for review Issue/PR is waiting for a writer's review label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set using git Content related to using git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants