Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octokit throttling behind env var #967

Closed
wants to merge 2 commits into from

Conversation

jorgectf
Copy link
Contributor

@jorgectf jorgectf commented Jan 18, 2024

Replaced by #974.

@jorgectf jorgectf changed the title Add octokit throttling behing env var Add octokit throttling behind env var Jan 18, 2024
@jorgectf jorgectf force-pushed the jorgectf/throttling branch from e6877c3 to 372ff00 Compare January 18, 2024 10:14
@jorgectf jorgectf marked this pull request as ready for review January 18, 2024 10:22
@jorgectf jorgectf force-pushed the jorgectf/throttling branch 2 times, most recently from 8366569 to 9b38917 Compare January 18, 2024 20:26
@jorgectf jorgectf marked this pull request as draft January 18, 2024 22:18
@jorgectf jorgectf force-pushed the jorgectf/throttling branch from 9b38917 to 1ae25b2 Compare January 19, 2024 13:28
@jorgectf jorgectf marked this pull request as ready for review January 19, 2024 13:33
@charisk
Copy link
Contributor

charisk commented Jan 23, 2024

Thank you for your PR @jorgectf! It seems reasonable to do this. We could even remove the environment variable, but might be good to keep it until we've done enough testing to be happy with it.

Before we look at the code closely, would you mind looking at the failing integration tests?

@jorgectf
Copy link
Contributor Author

jorgectf commented Jan 23, 2024

Before we look at the code closely, would you mind looking at the failing integration tests?

Sure! I see it's an auth error, maybe the bot token is expired? Or that the jorgectf/throttling branch only exists in my fork? I'm going to push it to this repo and see if it works.

@jorgectf
Copy link
Contributor Author

Before we look at the code closely, would you mind looking at the failing integration tests?

Sure! I see it's an auth error, maybe the bot token is expired? Or that the jorgectf/throttling branch only exists in my fork? I'm going to push it to this repo and see if it works.

Doesn't work either: https://github.com/github/codeql-variant-analysis-action/actions/runs/7584440489/job/20781386091?pr=967#step:2:57

Could it be the bot token? @charisk

@charisk
Copy link
Contributor

charisk commented Jan 24, 2024

Could it be the bot token? @charisk

It seems to work okay for me: https://github.com/github/codeql-variant-analysis-action/actions/runs/7637745463

@jorgectf
Copy link
Contributor Author

Oh, the workflow was not using the secret properly, as this PR comes from a fork. I've opened #974 which comes from this repository.

@jorgectf jorgectf closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants