handle rate limit exhaustion as configuration error #2795
Closed
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfyson
changed the title
There was a problem hiding this comment.
PR Overview
This PR introduces a new error category, RateLimitExhausted, to the cli-errors module so that API rate limit errors are treated as configuration errors.
- Added RateLimitExhausted to the CliConfigErrorCategory enum in both TypeScript and JavaScript files.
- Added regular expression candidates to match rate limit exhaustion error messages in both code paths.
Reviewed Changes
| File | Description |
|---|---|
| src/cli-errors.ts | Added RateLimitExhausted enum value and its regex candidate. |
| lib/cli-errors.js | Added RateLimitExhausted property and its regex candidate to object. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
CliConfigErrorCategoryofRateLimitExhaustedto thecli-errorsmodule. This will ensure that such errors are treated as configuration errors, and hence not as an indicator of availability with the CodeQL Action.Merge / deployment checklist