Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 5099 #5100

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix 5099 #5100

merged 4 commits into from
Oct 11, 2024

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Oct 11, 2024 •
edited
Loading

Add another check to assure folders without a .git directories aren't accepted.

Fixes #5099

Tasks

  • reproduce
  • fix
  • fix in gitoxide for repo-classification (unrelated issue, actually)
  • use latest main of gitoxide

Notes for the Reviewer

  • I took the liberty and changed the integration test layout to the 'new' style that I have been adopting over at gitoxide as well. It leads to cleaner directories layouts in tests/ and is overall easier to work with.
    Here is a more elaborate example for that:

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 11, 2024
@Byron Byron mentioned this pull request Oct 11, 2024
Merged
1 task
@Byron Byron marked this pull request as ready for review October 11, 2024 17:00
@Byron Byron requested a review from Caleb-T-Owens October 11, 2024 17:00
Caleb-T-Owens
Caleb-T-Owens approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Byron Byron merged commit 44a6125 into gitbutlerapp:master Oct 11, 2024
16 of 17 checks passed
@Byron Byron deleted the fix-5099 branch October 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-T-Owens Caleb-T-Owens Caleb-T-Owens approved these changes

Assignees
No one assigned
Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't open submodules as projects
2 participants
@Byron @Caleb-T-Owens