Improved the graceful shutdown and restart section and removed dead code #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2288 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 41 41
Lines 2298 2298
=======================================
Hits 2263 2263
Misses 20 20
Partials 15 15 Continue to review full report at Codecov.
|
appleboy
approved these changes
Mar 22, 2020
byebyebruce
pushed a commit
to byebyebruce/gin
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial purpose was to remove the dead code from the example. Still, I hooked up a few improvements as well, such as comments in the code and the text structure separating the usage of third-party libraries from the usage of the built-in packages to handle it manually.
I also changed the term "graceful stop" to graceful shutdown, which seems to be more common in the web, therefore, it would make it easier to find the text.
Related pull request gin-gonic/examples#33