Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Bugfix/article ID parsing issue #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iacopy
Copy link

@iacopy iacopy commented Mar 22, 2020

Thanks for the useful and well written library!

This minimal fix make the parser returning only the paper pubmed id.
Before, also the ids of the citations papers were returned.(they are within the ReferenceList element of the xml).

Fixes #22

An alternative XPath to be used:
path = ".//PubmedData/ArticleIdList/ArticleId[@idtype='pubmed']"

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests (if applicable)?
  2. Have you lint your code locally prior to submission (use flake8)?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@iacopy iacopy changed the title Fix article ID parsing issue Bugfix/article ID parsing issue Mar 22, 2020
@ritvikvipra ritvikvipra mentioned this pull request May 7, 2020
7 tasks
This fix avoids returning also the IDs of cited
papers
(they are within the ReferenceList element of the xml).

Note: this issue was tracked as 22 on the original repository (now archived)

An alternative XPath to be used:
path = ".//PubmedData/ArticleIdList/ArticleId[@idtype='pubmed']"
@iacopy iacopy force-pushed the fix-article-pmid-parsing-issue branch from ced77e5 to 54cd94a Compare December 7, 2021 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Articles id parsing issue
1 participant