This repository was archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Cherry branch #25
Open
mbullmanFHCRC
wants to merge
20
commits into
gijswobben:master
Choose a base branch
from
mbullmanFHCRC:cherry-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cherry branch #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olves adding new _extract fucntions, __slots__ entries, and self.Field references for each added field
…n't working. I need to look up some XML stuff
…ORCID. Unfortunately, this meant removing the very clean list comprehesnion the original author was using.
…nown error where ORCIDs could end with an 'X' instead of a numerial. Should now be catching all ORCIDs properly... hopefully
…s rather than a single string of text values. This allows for more intuitive parsing of listed elements (IMO). I then used this new function in _extractArticleIDs to allow for easier extraction of articleIDs. And cleaner code I think. Overall, with this change. I think we're basically bringing in all the fields we may or may not need. So now we can start working on getting this formatted out and saved to disk somewhere
…MedType' method/field to both books and article. This is so we can filter out book types
…ut I think it is working such that it will always return something. Hopefully. Still needs to be validated against existing processes
accidently deleted branch / PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
I only want to commit 27aeba4 / 989a237, I've tried cherry-picking the changes but can't seem to get it to work.
Basically, when you're using getContent / xml_element.findall(path), if you run into italics or bolds in the xml text you run into issues, since the xml parsers doesn't handle those edge cases correctly.
To fix this I'm removing , , , from the response string that _get returns before xml.fromstring(response) is called.
It seems to work on the quick test I did on my own system, I think there are other special characters which could be added to the regex if needed, but for now this works for my purposes. I saw issue #23 referenced incomplete abstract which was a symptom I saw on my end. The issue also arises in ArticleTitle if italics or bolds are used.
I didn't test this too extensively, hopefully it's not breaking anything else down the line.
Sorry for the extra commits! I'll try and figure out how to cherry-pick better in the future.