Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #161: Adding packages base support on our pkg config file #5

Merged

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jul 5, 2024

Summary by Sourcery

Added support for base packages in the GhostBSD package configuration file by introducing new entries for GhostBSD-base and GhostBSD_FR-base repositories.

@ericbsd ericbsd requested review from a team July 5, 2024 01:39
@ericbsd ericbsd self-assigned this Jul 5, 2024
@ericbsd ericbsd linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Jul 5, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #161 by adding base support configurations to the GhostBSD package configuration file. The changes include disabling the default GhostBSD and GhostBSD-base repositories and adding a new configuration block for the GhostBSD_FR-base repository with the necessary URL, signature type, public key, and enabled status.

File-Level Changes

Files Changes
usr/local/etc/pkg/repos/GhostBSD.conf.fr Added base support configurations for GhostBSD repositories, including disabling default repositories and adding a new base repository configuration.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit 39a9cab into master Jul 6, 2024
@ericbsd ericbsd deleted the 161-add-a-config-file-for-pkgbase-in-ghostbsd-pkg-conf branch July 6, 2024 23:32
@ericbsd ericbsd added the task label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a config file for pkgbase in ghostbsd-pkg-conf.
1 participant