Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: detect multiple devices by deviceUUID instead of deviceID #8022

Merged
merged 3 commits into from
Jun 21, 2024
Merged

vulkan: detect multiple devices by deviceUUID instead of deviceID #8022

merged 3 commits into from
Jun 21, 2024

Conversation

Adriankhl
Copy link
Contributor

Fixes #7997

@github-actions github-actions bot added the Vulkan Issues specific to the Vulkan backend label Jun 20, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 20, 2024
@0cc4m 0cc4m self-requested a review June 20, 2024 06:57
0cc4m
0cc4m requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works. I just have a few small comments about the code style, once you addressed those this can be merged.

@Adriankhl
Copy link
Contributor Author

@0cc4m ok done

@Adriankhl Adriankhl force-pushed the fix-vulkan-deviceID branch from e4e0d09 to 2f290b5 Compare June 20, 2024 13:44
0cc4m
0cc4m requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I missed that, it seemed to be working before. You need to actually fill the old_id.

0cc4m
0cc4m approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, now it's working as intended!

@0cc4m 0cc4m merged commit 557b653 into ggml-org:master Jun 21, 2024
63 of 64 checks passed
HoiV added a commit to HoiV/llama_dc.cpp that referenced this pull request Jun 24, 2024
@HoiV
Merge remote-tracking branch 'origin/master' into hv/matmul
abb62bb 
Update hv/matmul up to:
commit 557b653 (HEAD -> master, origin/master, origin/HEAD)
Author: k.h.lai <adrian.k.h.lai@outlook.com>
Date:   Fri Jun 21 16:28:20 2024 +0800

    vulkan: detect multiple devices by deviceUUID instead of deviceID (ggml-org#8022)

commit 7d5e877
Author: Eve <139727413+netrunnereve@users.noreply.github.com>
Date:   Fri Jun 21 05:57:36 2024 +0000

    ggml : AVX IQ quants (ggml-org#7845)

...
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
@Adriankhl @NeoZhangJianyu
vulkan: detect multiple devices by deviceUUID instead of deviceID (gg…
ed316c6 
…ml-org#8022)

* vulkan: detect multiple devices by deviceUUID instead of deviceID

* vulkan: remove unneeded variables

* vulkan: fix id query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Vulkan backend not detecting multiple GPUs anymore
3 participants
@Adriankhl @0cc4m @mofosyne