Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stream updating in the SwiftUI example #7754

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

shu223
Copy link
Contributor

@shu223 shu223 commented Jun 5, 2024

Enabled the chat completion to stream in the examples/llama.swiftui sample project.

llamacpp_stream.mp4

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 5, 2024
@shu223
Copy link
Contributor Author

shu223 commented Jun 20, 2024

@ggerganov What should I do to be merged? The check failure seems not for this PR.
CleanShot 2024-06-21 at 08 51 05

@ggerganov ggerganov merged commit 0e64591 into ggml-org:master Jun 21, 2024
64 of 66 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants