-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial import of golang bindings #287
Conversation
This looks very well done - thank you for the contribution! Regarding the need for the I'll let this sit for a day before merging. |
Thanks Georgi. On the AVX2 option, I'll take a look at using make and I can add the github actions for tests and building as well, but probably not going to get to them this week. I can send you some more pull requests for those changes later, and then begin to build out the full functionality and live streaming option in go examples. Thanks for your comments and continued efforts on this. |
@ggerganov any chance we can get this merged? |
Awesome stuff !!
@david I think we need to look at a few little tidyups to simplify usage of
the go library.
It seems we can use environment variables to pass C and LD options to the
cgo implementation.
This would also allow someone to point to whisper.h outside of their go
application tree (keeping things near)
Have you ever done this before?
…On Tue, 20 Dec 2022, 4:54 pm Georgi Gerganov, ***@***.***> wrote:
Merged #287 <#287> into
master.
—
Reply to this email directly, view it on GitHub
<#287 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALQR62C4X3Y2OV63LC7SGLWOFJ3HANCNFSM6AAAAAATCOLUDM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Thanks. Yep, I'll fix that up and improve the documentation for it in the next few days:
|
* Initial import of golang bindings * Updated makefile rules * Updated bindings * Makefile update to add in more tests
* Initial import of golang bindings * Updated makefile rules * Updated bindings * Makefile update to add in more tests
* Initial import of golang bindings * Updated makefile rules * Updated bindings * Makefile update to add in more tests
I've added some bindings for golang here. They are pretty basic but I've tested on Darwin x64_86 and Debian arm64. There is one example (go-whisper) for the most basic case of using the bindings.
Linked to issue #269