Bump to latest wgpu-core #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
almarklein
commented
May 12, 2021
•
almarklein
commented
- Bump to wgpu-core (gets newer Naga too).
- Some fixes to adjust to changes in wgpu-core.
- Implement missing pieces in bind groups and bind group layouts (only buffers were supported so far).
almarklein
commented
May 12, 2021
|
This is ready for review. Thanks for the help! |
|
There may be more regressions that I'll run into (e.g. #96), but can fit those in a new PR. I updated to the latest wgpu-core where naga was bumped to 25. In that PR you noted:
What exactly are the implications of that? |
|
Also fixed some (but not all) of the missing functions reported in #96 |
kvark
approved these changes
May 16, 2021
| comparison: false, | ||
| }, | ||
| native::WGPUSamplerBindingType_Comparison => wgt::BindingType::Sampler { | ||
| filtering: false, |
| pub unsafe extern "C" fn wgpuQueueWriteTexture( | ||
| queue: id::QueueId, | ||
| destination: native::WGPUImageCopyTexture, | ||
| data: *const u8, // TODO: Check - this might not follow the header |
There was a problem hiding this comment.
header has *const c_void basically. Probably fine then?
|
Great stuff, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.