This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
I admit, this is a real PITA, and this code reflects it.
The workaround I wanted to implement was to issue an
Load
into the matrix if we see it being row-major, followed byTranspose
, then pretending that it was column-major all this time.The problem is that there are many ways to cross that "ima matrix" barrier:
OpAccessChain
doesn't have intermediate IDs, so we can't do it iterativelyIf anybody can have a better idea, I'd love to consider it!