Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip anchor checking for URL with prefix in config #812

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

TjeuKayim
Copy link
Contributor

@TjeuKayim TjeuKayim commented Oct 5, 2019

Fixes #805

zola check

The anchors of external URLs will not be checked if it starts with one of the configured prefixes.
So false positives can be put on the ignore list, like https://github.com/rust-lang/rust/blob/c772948b687488a087356cb91432425662e034b9/src/librustc_back/target/mod.rs#L194-L214: Anchor `#L194-L214 and https://caniuse.com/#feat=css-filters.

# Link Checker: skip anchor checking for external URLs that start with these prefixes
link_checker_skip_anchor_prefixes = [
    "https://caniuse.com/",
]

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@TjeuKayim TjeuKayim force-pushed the anchor-ignore branch 2 times, most recently from e4b6f8b to 26ad461 Compare October 5, 2019 15:48
Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, everything looks great otherwise.

@TjeuKayim TjeuKayim requested a review from Keats October 13, 2019 11:42
@Keats Keats merged commit b2dc2ce into getzola:next Oct 14, 2019
@Keats
Copy link
Collaborator

Keats commented Oct 14, 2019

Great, thanks!

Keats pushed a commit that referenced this pull request Oct 24, 2019
* cargo fmt & clippy

* Skip anchor checking for URL with prefix in config
Keats pushed a commit that referenced this pull request Feb 3, 2020
* cargo fmt & clippy

* Skip anchor checking for URL with prefix in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants