feat(dev): On Apple arm64 install hosted confluent-kafka wheel #29013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
force-pushed
the
armenzg/dev/confluent-kafka-apple-m1
branch
from
a5cab19 to
768490f
Compare
12 tasks
armenzg
changed the base branch from
master
to
armenzg/dev/downgrade-psycopg2-binary
armenzg
force-pushed
the
armenzg/dev/downgrade-psycopg2-binary
branch
from
81f6a76 to
d6b4c44
Compare
armenzg
added
the
Component: Developer Environment
armenzg
force-pushed
the
armenzg/dev/confluent-kafka-apple-m1
branch
from
5f60817 to
1c6097f
Compare
armenzg
force-pushed
the
armenzg/dev/confluent-kafka-apple-m1
branch
from
1c6097f to
aa35528
Compare
Fixes regression introduced in #29058. On Big Sur, we cannot install Python 3.6.x without patching the source code first.
For the incompatibility issue with Django visit [this issue][incompatible], In this PR, we're going to downgrade to the compatible 2.8.6 version (thus, matching the Python 3.6 version), removing the need to install `postgresql` (this means partially reverting #28607) and instead installing a wheel I built on my machine that I have stored in GC storage. Fixes #28958 [incompatible]: psycopg/psycopg2#1293
armenzg
force-pushed
the
armenzg/dev/downgrade-psycopg2-binary
branch
from
d6b4c44 to
37e4c49
Compare
There's no `arm64` wheel for confluent-kafka, thus, it needs to be built as part of the `pip install` step. Instead of waiting for official support, I've uploaded the wheel I produced into a GC bucket. Alternatively, we would automate a convoluted build process (see [issue][upstream] for details). Fixes #28429. [upstream]: confluentinc/confluent-kafka-python#1190
armenzg
force-pushed
the
armenzg/dev/confluent-kafka-apple-m1
branch
from
aa35528 to
239b611
Compare
armenzg
commented
Oct 7, 2021
armenzg
changed the title
joshuarli
approved these changes
Oct 7, 2021
Base automatically changed from
armenzg/dev/downgrade-psycopg2-binary
to
armenzg/devenv/fix-pyenv-on-intel
October 7, 2021 20:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no
arm64wheel for confluent-kafka, thus, we need to build our own and install it from there.Alternatively, we would have to automate a convoluted build work around (see issue1 for details).
Fixes #28429.
Footnotes
https://github.com/confluentinc/confluent-kafka-python/issues/1190 ↩