Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default slug generation for Crons mixin #2168

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

sl0thentr0py
Copy link
Member

Closes #2138

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2168 (3d27cae) into master (e082644) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
+ Coverage   97.30%   97.33%   +0.02%     
==========================================
  Files          97       97              
  Lines        3638     3641       +3     
==========================================
+ Hits         3540     3544       +4     
+ Misses         98       97       -1     
Components Coverage Δ
sentry-ruby 98.02% <100.00%> (+<0.01%) ⬆️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 93.70% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit a418b54 into master Nov 13, 2023
@sl0thentr0py sl0thentr0py deleted the neel/cron-slugs branch November 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve slug generation for crons
2 participants