Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip private _config context in Sidekiq 7+ #1967

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Skip private _config context in Sidekiq 7+ #1967

merged 2 commits into from
Dec 19, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 18, 2022

Fixes #1956

@st0012 st0012 added this to the 5.8.0 milestone Dec 18, 2022
@st0012 st0012 self-assigned this Dec 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 98.04% // Head: 98.02% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (29e0221) compared to base (dce8ef0).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
- Coverage   98.04%   98.02%   -0.02%     
==========================================
  Files         157      157              
  Lines        9826     9831       +5     
==========================================
+ Hits         9634     9637       +3     
- Misses        192      194       +2     
Impacted Files Coverage Δ
sentry-sidekiq/spec/sentry/sidekiq_spec.rb 94.80% <25.00%> (-1.87%) ⬇️
...entry-sidekiq/lib/sentry/sidekiq/context_filter.rb 100.00% <100.00%> (ø)
sentry-resque/lib/sentry/resque.rb 100.00% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012 st0012 requested a review from sl0thentr0py December 18, 2022 19:18
@st0012 st0012 merged commit 81b0f9b into master Dec 19, 2022
@st0012 st0012 deleted the fix-#1956 branch December 19, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-sidekiq doesn't record configuration with Sidekiq 7.x
3 participants