Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute with_scope's block even when SDK is not initialized #1897

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 15, 2022

Fixes #1896

@st0012 st0012 added this to the 5.5.0 milestone Sep 15, 2022
@st0012 st0012 self-assigned this Sep 15, 2022
@st0012 st0012 requested a review from sl0thentr0py September 15, 2022 12:28
@st0012 st0012 merged commit ae13d7d into master Sep 15, 2022
@st0012 st0012 deleted the fix-#1896 branch September 15, 2022 12:33
HashNuke added a commit to HashNuke/sentry-ruby that referenced this pull request Aug 12, 2024
When Sentry is not initialized, any block of code that is wrapped in `Sentry.configure_scope` is not run.

PR getsentry#1897 fixed this issue for `Sentry.with_scope`, but I believe the same behaviour should apply for the `Sentry.configure_scope` too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry.with_scope block is not called when Sentry is not initialized
2 participants