Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports for sphinx #3986

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix circular imports for sphinx #3986

merged 2 commits into from
Jan 22, 2025

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (37d8599) to head (998c15c).
Report is 2 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/scope.py 55.55% 4 Missing ⚠️
sentry_sdk/integrations/opentelemetry/scope.py 83.33% 1 Missing ⚠️
sentry_sdk/tracing.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #3986      +/-   ##
==============================================
+ Coverage       84.22%   84.35%   +0.12%     
==============================================
  Files             141      141              
  Lines           14256    14240      -16     
  Branches         2230     2225       -5     
==============================================
+ Hits            12007    12012       +5     
+ Misses           1546     1524      -22     
- Partials          703      704       +1     
Files with missing lines Coverage Δ
sentry_sdk/api.py 94.25% <100.00%> (+0.06%) ⬆️
sentry_sdk/client.py 85.19% <100.00%> (ø)
.../integrations/opentelemetry/contextvars_context.py 100.00% <100.00%> (ø)
...entry_sdk/integrations/opentelemetry/propagator.py 83.72% <100.00%> (ø)
sentry_sdk/integrations/opentelemetry/utils.py 82.00% <100.00%> (+0.22%) ⬆️
sentry_sdk/integrations/opentelemetry/scope.py 95.69% <83.33%> (-1.01%) ⬇️
sentry_sdk/tracing.py 79.57% <50.00%> (-0.18%) ⬇️
sentry_sdk/scope.py 81.71% <55.55%> (+2.95%) ⬆️

... and 1 file with indirect coverage changes

Base automatically changed from neel/potel/scope-cleanup to potel-base January 22, 2025 15:49
@sl0thentr0py sl0thentr0py merged commit 2894963 into potel-base Jan 22, 2025
138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/sphinx branch January 22, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants