Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nullcontext from wsgi and asgi #3983

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sl0thentr0py
Copy link
Member

mypy was complaining too so just removed it

@sl0thentr0py sl0thentr0py marked this pull request as ready for review January 20, 2025 19:19
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (ea06dab) to head (1425acf).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/asgi.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           potel-base    #3983   +/-   ##
===========================================
  Coverage       84.11%   84.11%           
===========================================
  Files             141      141           
  Lines           14269    14269           
  Branches         2234     2235    +1     
===========================================
  Hits            12003    12003           
  Misses           1565     1565           
  Partials          701      701           
Files with missing lines Coverage Δ
sentry_sdk/integrations/wsgi.py 94.00% <100.00%> (+0.12%) ⬆️
sentry_sdk/integrations/asgi.py 91.89% <88.88%> (+0.50%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 3c7bb1e into potel-base Jan 21, 2025
136 of 138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/remove-nullcontext branch January 21, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants