Fix langchain integration #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add optional `parent_span` argument to POTelSpan constructor and fix `start_child` * `run_id` is reused for the top level pipeline in langchain, so make sure to close that span or else we get orphans * Dont't use context manager enter/exit since we're doing manual span management * Set correct statuses while finishing the spans
❌ 253 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sl0thentr0py
commented
Jan 13, 2025
| @@ -291,3 +291,17 @@ def _common_span_transaction_attributes_as_json(self, span): | |||
| common_json["tags"] = tags | |||
|
|
|||
| return common_json | |||
|
|
|||
| def _log_debug_info(self): | |||
There was a problem hiding this comment.
this is just a helper for future span processor debugging
sentrivana
approved these changes
Jan 13, 2025
Comment on lines
+295
to
+307
| def _log_debug_info(self): | ||
| # type: () -> None | ||
| import pprint | ||
|
|
||
| pprint.pprint( | ||
| { | ||
| format_span_id(span_id): [ | ||
| (format_span_id(child.context.span_id), child.name) | ||
| for child in children | ||
| ] | ||
| for span_id, children in self._children_spans.items() | ||
| } | ||
| ) |
There was a problem hiding this comment.
Do we want to keep this?
There was a problem hiding this comment.
Nevermind, I see your comment now. Fine to keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent_spanargument toPOTelSpanconstructor and fixstart_childrun_idis reused for the top level pipeline, so make sure to close that span or else we get orphans