-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract span attrs from RQ job object & fix tests #3786
Extract span attrs from RQ job object & fix tests #3786
Conversation
❌ 622 Tests Failed:
View the top 2 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
@@ -54,8 +64,8 @@ def setup_once(): | |||
old_perform_job = Worker.perform_job | |||
|
|||
@ensure_integration_enabled(RqIntegration, old_perform_job) | |||
def sentry_patched_perform_job(self, job, *args, **kwargs): | |||
# type: (Any, Job, *Queue, **Any) -> bool | |||
def sentry_patched_perform_job(self, job, queue, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that the signature of perform_job
is stable in the minimal supported version and in the current release. There are actually no args
and kwargs
, just job
and queue
, but let's do it like this for forwards compat.
Forgot migration guide, added now |
rq_job
with some span attrs to populate the sampling context in traces samplertest_rq
passmessage
if we already explicitly setop
This is not great since we have to serialize everything (args, kwargs, function to be executed). But it's the best we can do with span attrs.