Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumbs in redis #3680

Merged
merged 15 commits into from
Oct 22, 2024
Merged

Fix breadcrumbs in redis #3680

merged 15 commits into from
Oct 22, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 22, 2024 •
edited
Loading

This moves the creation of redis breadcrumbs from the maybe_create_breadcrumbs_from_span into the integrations. And as well fixes some span related tests by using render_span_tree.

@antonpirker antonpirker self-assigned this Oct 22, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

❌ 2581 Tests Failed:

Tests completed Failed Passed Skipped
20295 2581 17714 4412
View the top 3 failed tests by shortest run time 
tests.integrations.asgi.test_asgi test_capture_transaction_with_error
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker marked this pull request as ready for review October 22, 2024 11:59
sentrivana
sentrivana approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for keeping this readable. I think this is a good level of abstraction.

@antonpirker antonpirker merged commit 949ff5b into potel-base Oct 22, 2024
16 of 120 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/fix-breadcrumbs-in-redis branch October 22, 2024 14:56
@antonpirker antonpirker mentioned this pull request Oct 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

@antonpirker antonpirker

Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana