Make transaction names work #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2940 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sentrivana
approved these changes
Oct 11, 2024
sl0thentr0py
force-pushed
the
neel/potel/tx-name
branch
from
9d693f7 to
fad9c17
Compare
* while sending the event in the final payload, the transaction name
will be picked up from the attributes `sentry.name` or fallback to the
`description` when we only have otel instrumentation
* for populating DSC in the head case, we are doing a best attempt
solution and fetching the transaction name/source from the current and
isolation scopes
* NOTE that there are cases where this will be
inaccurate if we never set the transaction name on the scope in some
integration, so we will go through and fix those cases separately.
sl0thentr0py
force-pushed
the
neel/potel/tx-name
branch
from
fad9c17 to
1957fff
Compare
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry.nameor fallback to thedescriptionwhen we only have otel instrumentation