Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set internal_error span status on span context manager exit #3642

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Set internal_error span status on span context manager exit #3642

merged 1 commit into from
Oct 10, 2024

Conversation

sl0thentr0py
Copy link
Member

No description provided.

sentrivana
sentrivana approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sl0thentr0py sl0thentr0py merged commit c6ad235 into potel-base Oct 10, 2024
13 of 109 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/span-status-fix branch October 10, 2024 13:36
@sl0thentr0py sl0thentr0py mentioned this pull request Oct 10, 2024
Draft
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

❌ 2947 Tests Failed:

Tests completed Failed Passed Skipped
20072 2947 17125 4443
View the top 3 failed tests by shortest run time 
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_spans_with_pii
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @sentrivana