Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head SDK DSC population #3599

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Head SDK DSC population #3599

merged 1 commit into from
Oct 4, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Oct 2, 2024

  • Populates a DSC with correct values when we don't have an incoming trace.
  • We rely on trace_state.add only adding new keys to the tracestate so these values will be populated in the first samplign decision on the root and just be propagated further.

Note that transaction name is missing here for now and will be dealt with separately as part of the transaction name PRs.

closes #3479

Copy link

codecov bot commented Oct 2, 2024

❌ 2928 Tests Failed:

Tests completed Failed Passed Skipped
17754 2928 14826 1727
View the top 3 failed tests by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_spans
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Note that transaction name is missing here for now
@sl0thentr0py
Copy link
Member Author

tested both head SDK and that child SDK setups continue to work

head SDK screenshot:

image

@sl0thentr0py sl0thentr0py merged commit b65b742 into potel-base Oct 4, 2024
14 of 122 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/dsc-head branch October 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants