Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Remove sentry_sdk.push_scope #3408

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat(api): Remove sentry_sdk.push_scope #3408

merged 1 commit into from
Aug 7, 2024

Conversation

szokeasaurusrex
Copy link
Member

Also, remove any tests that test sentry_sdk.push_scope.

BREAKING CHANGE: Remove sentry_sdk.push_scope.

Closes #3403

@szokeasaurusrex
feat(api): Remove sentry_sdk.push_scope
eb9efd5 
Also, remove any tests that test `sentry_sdk.push_scope`.

BREAKING CHANGE: Remove `sentry_sdk.push_scope`.

Closes #3403
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 12183 tests with 1 failed, 10611 passed and 1571 skipped.

View the full list of failed tests

py3.7-common

  • Class name: tests.profiler.test_transaction_profiler
    Test name: test_profile_captured

    tests/profiler/test_transaction_profiler.py:290: in test_profile_captured
        assert len(items["profile"]) == 1
    E   assert 0 == 1
    E     +0
    E     -1

@szokeasaurusrex szokeasaurusrex merged commit 3936502 into potel-base Aug 7, 2024
120 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/remove-push_scope branch August 7, 2024 15:08
@szokeasaurusrex szokeasaurusrex linked an issue Aug 7, 2024 that may be closed by this pull request
Remove push_scope #3403
Closed
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
@szokeasaurusrex @sentrivana
feat(api): Remove sentry_sdk.push_scope (#3408)
7ac4d71 
Also, remove any tests that test `sentry_sdk.push_scope`.

BREAKING CHANGE: Remove `sentry_sdk.push_scope`.

Closes #3403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove push_scope
2 participants
@szokeasaurusrex @sentrivana