fix(profiler): Add function name to profiler frame cache #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapper functions can take on the same name as the wrapped function. This means that if a decorator is used to wrap different functions, even though the filename and line number will be the same for all instances of the frame, the function name can vary. Add the function name to the cache to avoid these cache collisions.
sentrivana
approved these changes
Jun 13, 2023
sentrivana
deleted the
txiao/fix/add-function-name-to-profiler-frame-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper functions can take on the same name as the wrapped function. This means that if a decorator is used to wrap different functions, even though the filename and line number will be the same for all instances of the frame, the function name can vary. Add the function name to the cache to avoid these cache collisions.