Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend ESM hooks options for iitm v1.10.0 #13016

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jul 23, 2024

import-in-the-middle@1.10.0 supports regular expressions for include and exclude.

Is there a risk here that users might not have the latest version of import-in-the-middle in their dependencies?

@mydea
Copy link
Member

mydea commented Jul 23, 2024

Hmm yeah, users will OOTB not get an updated version of this. One thing we could do I guess is add an import-in-the-middle dependency ourselves for ^1.10.0? Does that make sense? 🤔 That may help sometimes if users dedupe correctly, but I guess even then it may not work for some scenarios to force updating this to latest 🤔

@mydea
Copy link
Member

mydea commented Jul 23, 2024

FWIW this is possibly also the reason why some users report that using exclude / import is not working for them - they may be "stuck: on 1.8.1 which is the minimum version required by otel 🤯

@timfish
Copy link
Collaborator Author

timfish commented Jul 23, 2024

add an import-in-the-middle dependency ourselves for ^1.10.0? Does that make sense?

Since we actually register import-in-the-middle/hook.mjs as our hook, this is probably a good idea!

@mydea
Copy link
Member

mydea commented Jul 23, 2024

I think you need to run yarn and commit the lockfile? Also FWIW I notice that when we do this it still keeps the 1.8.1 version in our lockfile :( need to deduplicate the lockfile to get a consistent version :( but better than nothing, I guess!

@AbhiPrasad AbhiPrasad merged commit 04a26a4 into develop Jul 23, 2024
123 checks passed
@AbhiPrasad AbhiPrasad deleted the feat/extend-esm-hook-types branch July 23, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants