Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting in-app-includes/in-app-excludes via AndroidManifest.xml #4240

Merged

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 7, 2025

📜 Description

We officially support it according to our docs, but actually it's not implemented.

💡 Motivation and Context

Fixes #2617

💚 How did you test it?

Added tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.78 ms 463.80 ms 72.02 ms
Size 1.58 MiB 2.21 MiB 642.10 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should update the configuration/options.mdx docs of both java and android as they refer to in-app-include(/exclude) where it should be plural in-app-includes instead

@markushi
Copy link
Member Author

markushi commented Mar 7, 2025

LGTM, we should update the configuration/options.mdx docs of both java and android as they refer to in-app-include(/exclude) where it should be plural in-app-includes instead

Docs PR is up as well now: getsentry/sentry-docs#12954

@markushi markushi merged commit 7074d0b into main Mar 7, 2025
35 checks passed
@markushi markushi deleted the markushi/fix/support-for-in-app-includes-excludes-manifest branch March 7, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InAppInclude option not added via AndroidManifest.xml
2 participants