Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SentryOptions.continuousProfilesSampleRate #4013

Merged

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Dec 23, 2024

📜 Description

added SentryOptions.continuousProfilesSampleRate
now continuous profiling is disabled if continuousProfilesSampleRate is 0
profiles directory is created when continuous profiling is enabled, too
continuous profiling decision is passed to SentryAppStartProfilingOptions
app start continuous profiling is sampled, too

#skip-changelog

💡 Motivation and Context

Add sample rate to continuous profiling
Part 7 of #3710

💚 How did you test it?

Unit test

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

now continuous profiling is disabled if continuousProfilesSampleRate is 0
profiles directory is created when continuous profiling is enabled, too
continuous profiling decision is passed to SentryAppStartProfilingOptions
app start continuous profiling is sampled, too
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b112177

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.43 ms 472.32 ms 76.89 ms
Size 1.65 MiB 2.31 MiB 681.34 KiB

Baseline results on branch: feat/continuous-profiling-part1

Startup times

Revision Plain With Sentry Diff
672ac2a 392.98 ms 453.73 ms 60.76 ms

App size

Revision Plain With Sentry Diff
672ac2a 1.65 MiB 2.31 MiB 680.97 KiB

@stefanosiano stefanosiano marked this pull request as ready for review December 23, 2024 16:22
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
@stefanosiano stefanosiano merged commit e70d583 into feat/continuous-profiling-part1 Dec 23, 2024
27 of 29 checks passed
@stefanosiano stefanosiano deleted the feat/continuous-profiling-part7 branch December 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants