Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture OpenTelemetry span events #3564

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Capture OpenTelemetry span events #3564

wants to merge 8 commits into from

Conversation

adinauer
Copy link
Member

📜 Description

OpenTelemetry spans can have events attached. This PR allows us to capture exceptions from ExceptionEventData into Sentry if the captureOpenTelemetryEvents option is enabled.

💡 Motivation and Context

Allows us to capture more errors. Doesn't require extra Sentry dependencies on the application for capturing errors - the agent alone is enough to capture errors.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to 8.x.x July 11, 2024 07:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against acd3839

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 387.26 ms 503.32 ms 116.06 ms
Size 1.58 MiB 2.21 MiB 641.84 KiB

Previous results on branch: feat/poc-capture-otel-events

Startup times

Revision Plain With Sentry Diff
eab21c9 373.65 ms 471.24 ms 97.59 ms

App size

Revision Plain With Sentry Diff
eab21c9 1.58 MiB 2.21 MiB 641.59 KiB

Base automatically changed from 8.x.x to main January 9, 2025 15:47
@adinauer adinauer mentioned this pull request Feb 17, 2025
Open
@adinauer adinauer changed the title POTEL 36 - POC Capture OpenTelemetry Events Capture OpenTelemetry span events Mar 3, 2025
@adinauer adinauer marked this pull request as ready for review March 3, 2025 05:25
lcian
lcian approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @lcian