Support configurable parallelism #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemumma
approved these changes
Sep 16, 2024
| produce the requests for the target. This allows us to have a request ready as | ||
| soon as it is needed even when high volume is needed. | ||
|
|
||
| It is important to set this parameter accurately specifically when the worker |
There was a problem hiding this comment.
I personally wouldn't know how to set this number accurately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Producing large requests (like Clickhouse batches) takes time.
Running the worker in Kubernetes implies having a set number
of cores available.
This introduces the need to be able to configure the maximum
number of threads used to produce requests to have requests
ready when needed.
The longer it takes to build request the higher the parallelism.
The lower the number of cores the lower the parallelism in
order not to be throttled.
This also fixes the push-image script not to have the
artifact registry hardcoded.