This repository was archived by the owner on Apr 16, 2022. It is now read-only.
A solution for Bug #798 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has no information that the forms are being loaded from the server. Making a call to setWorking() in the current view makes the buttons in the Source/Target panel to go disabled until the unsetWorking method is call. I think this fixes the bug as the user won be able to click on reset (or reload) during the time the forms are being loaded, and also the user will have good feedback.
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
============================================
- Coverage 48.29% 48.28% -0.02%
Complexity 1641 1641
============================================
Files 195 195
Lines 10384 10387 +3
Branches 750 750
============================================
Hits 5015 5015
- Misses 5012 5015 +3
Partials 357 357
Continue to review full report at Codecov.
|
ggalmazor
approved these changes
Jan 23, 2020
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was caused by the fact that the Source/Target panel has no information that the forms are being loaded from the server. Making a call to setWorking() in the current view makes the buttons in the Source/Target panel to go disabled until the unsetWorking method is call. I think this fixes the bug as the user won be able to click on reset (or reload) during the time the forms are being loaded, and also the user will have good feedback.
Closes #
What has been done to verify that this works as intended?
I was able to reproduce the bug before the fix, after the fix i cannot hit the reset button while loading.
Why is this the best possible solution? Were any other approaches considered?
It uses the already created method setWorking that is intended for this kind of behavior
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The user won be able to cancel the form loading process, but i think that is ok.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
I dont think this need to be put explicitly in the documentation as is a minor fix.