This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Issue #799 Fix getting form name for form keys #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
|
Looking now |
dcbriccetti
reviewed
Sep 9, 2019
| <h:title>this-title-has-dashes</h:title> | ||
| <model> | ||
| <instance> | ||
| <data id="this-id-has-dashes"> |
There was a problem hiding this comment.
Let’s make the world a better place by not saying dash when we mean hyphen.
hyphen: -
en dash: –
em dash: —
your character: -. Yup, it’s a hyphen. :-)
There was a problem hiding this comment.
TIL that dashes are not hyphens :D
dcbriccetti
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #799
What has been done to verify that this works as intended?
Added an automated regression test
Why is this the best possible solution? Were any other approaches considered?
This is not an optimal solution because it involves reparsing form definitions to get their names, but changing the underlying JavaRosaParserWrapper is much riskier because more code depends on that.
Also, this change will become irrelevant once we have v2.0, so it feels like we wont' be running into much problems anyway.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There should be no changes in behavior due to this change.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.