This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Fix #732 - Disable the select all button on Export tab if list is empty #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
============================================
+ Coverage 47.52% 47.54% +0.01%
- Complexity 1469 1475 +6
============================================
Files 178 178
Lines 9668 9676 +8
Branches 672 673 +1
============================================
+ Hits 4595 4600 +5
- Misses 4783 4784 +1
- Partials 290 292 +2
Continue to review full report at Codecov.
|
|
Tests with success!! @opendatakit-bot unlabel "needs testing" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #732
What has been done to verify that this works as intended?
Manually tested with empty and filled forms list.
Why is this the best possible solution? Were any other approaches considered?
The approach used is similar to how things have been done in
PullPanel.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This fixes a minor UI bug. No risks.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No