Skip to content
This repository was archived by the owner on Apr 16, 2022. It is now read-only.

Issue 759 fix parsing times with unsupported offsets #760

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Issue 759 fix parsing times with unsupported offsets #760

merged 4 commits into from
Jul 16, 2019

Conversation

ggalmazor
Copy link
Contributor

@ggalmazor ggalmazor commented Jul 10, 2019

Closes #759

This PR has a stowaway change: removing the WhitespaceAround rule from the checkstyle config file:

  • This rule is super noisy because every time that someone makes a change to a UI form using IntelliJ's GUI Designer, it generates code in their companion classes that offends the rule at least once. If the form has customized fonts it's even worse because there are multiple offending lines that you need to search and change every time.
  • This rule can be annoying when dealing with no-op functions as () -> {}, forcing to write them with an empty space between the brackets, or simple enums such as enum Type {A, B}, forcing you to sandwich the enum values between whitespaces.
  • I don't think this particular rule helps us to write particularly easier to read code, so I've removed it to spare us from wasting more time on it.

What has been done to verify that this works as intended?

  • Added automated tests that verify that time values that would fail now work
  • Manually exported the form attached to the issue using the UI

Why is this the best possible solution? Were any other approaches considered?

No other approaches were considered because there's already another precedent of the same normalization with datetime values in submissions.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It feels a pretty safe change. I can't foresee any regression risk on this one.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

@kkrawczyk123
Copy link
Contributor

Testes with success!!
Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@ggalmazor ggalmazor merged commit d92b6c0 into getodk:master Jul 16, 2019
@ggalmazor ggalmazor deleted the issue_759_fix_parsing_times_with_unsupported_offsets branch July 16, 2019 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing time strings with unsupported offset format
4 participants