This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Issue 759 fix parsing times with unsupported offsets #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #759
This PR has a stowaway change: removing the
WhitespaceAround
rule from the checkstyle config file:() -> {}
, forcing to write them with an empty space between the brackets, or simple enums such asenum Type {A, B}
, forcing you to sandwich the enum values between whitespaces.What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
No other approaches were considered because there's already another precedent of the same normalization with datetime values in submissions.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It feels a pretty safe change. I can't foresee any regression risk on this one.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.