Added Filtering support for S3 lifecycle #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2018
|
Coverage decreased (-0.07%) to 92.463% when pulling 31de991b81452adf72384f7b89ce928408ed66e5 on mikegrima:s3lifecycle into 5fe575b on spulec:master. |
Also added `ExpiredObjectDeleteMarker`. closes getmoto#1533 closes getmoto#1479
mikegrima
changed the title
|
Don't merge in yet -- found a bug where the top-level |
mikegrima
changed the title
|
Should be fixed now. |
|
The boto/botocore upgrades should be good - we've recently released a version so folks can pin to that for a while if this changes causes them upgrade pain. |
|
Nice work, @mikegrima! I'll merge when the build finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Filtering support for S3 lifecycle and also added
ExpiredObjectDeleteMarker.Note: The
Filterfeature is pretty new, so I bumped up theboto3andbotocoreversions to the latest. @JackDanger Please let me know if this is a problem.closes #1533
closes #1479