[direct] improve error messages + test coverage #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
Jan 8, 2025
| @@ -47,97 +82,52 @@ private[kyo] object Validate: | |||
| |""".stripMargin | |||
| ) | |||
|
|
|||
| case tree @ Apply(TypeApply(Ident("defer"), _), _) => | |||
There was a problem hiding this comment.
This case was unnecessary. The error message for a missing now triggers first
fwbrasil
commented
Jan 8, 2025
| |• TRef and derivatives (kyo-stm)""".stripMargin | ||
| ) | ||
|
|
||
| case Return(_, _) => |
There was a problem hiding this comment.
Also unnecessary, it's not possible to have a return outside of def
fwbrasil
commented
Jan 8, 2025
| |}""".stripMargin)}""".stripMargin | ||
| ) | ||
|
|
||
| case Lambda(_, body) if !pure(body) => |
There was a problem hiding this comment.
This pattern match is wrong and I couldn't make it work. I've decided to remove because dotty-cps-async already produces an error message for this.
fwbrasil
commented
Jan 8, 2025
| @@ -0,0 +1,195 @@ | |||
| package kyo | |||
There was a problem hiding this comment.
I've removed DirectTest and replaced it with more complete PreludeTest and CoreTest suites
fwbrasil
commented
Jan 8, 2025
| } | ||
| } | ||
|
|
||
| // TODO Compiler crash because `Queue` is an opaque type without a type bound |
There was a problem hiding this comment.
I can't use pendingUntilFixed because the compiler crashes. I'll create an issue for this
fwbrasil
commented
Jan 8, 2025
| } | ||
| } | ||
|
|
||
| // TODO Compiler crash because `Queue` is an opaque type without a type bound |
hearnadam
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.