[scheduler] don't preempt task if worker queue is empty #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
Jan 6, 2025
| @@ -80,47 +80,6 @@ class SchedulerTest extends AnyFreeSpec with NonImplicitAssertions { | |||
| } | |||
| } | |||
|
|
|||
| "cycle" - { | |||
There was a problem hiding this comment.
It's not easy to test this at the scheduler level because, even if we submit more tasks, the concurrency regulator can introduce new workers. The behavior is covered in WorkerTest so I'm removing the tests here.
fwbrasil
force-pushed
the
worker-preempt-empty-queue
branch
from
565e533 to
0f29d26
Compare
hearnadam
approved these changes
Jan 6, 2025
fwbrasil
added a commit
that referenced
this pull request
Jan 9, 2025
There's no need to preempt the current task if the worker queue is empty and there isn't another task waiting for execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to preempt the current task if the worker queue is empty and there isn't another task waiting for execution.