[LOC-5969] Ensure compatibility with Local 9 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@electron/remote needs to be a direct dependency and not a devDependency under Local 9 (which upgraded Electron). Otherwise, the add-on fails to load and this error is visible in Local's console: /Applications/Local Beta.app/Contents/Resources/app.asar/node_modules/ @sentry/utils/dist/instrument.js:111 Error Loading Add-on: /Users/ user.name/Library/Application Support/Local Beta/addons/ local-addon-image-optimizer/lib/renderer.js TypeError: i.isDesktopCapturerEnabled is not a function An alternative is to refactor to replace @electron/remote with IPC calls, but that is a larger lift with bigger testing impact given use of remote.Menu, remote.MenuItem, remote.shell, and the reportAnalytics calls that currently trigger on menu events.
Same fix we applied here due to showItemInFolder flakiness in Electron under macOS: https://github.com/getflywheel/flywheel-local/pull/1888/files Just needed to get the parent folder path so we don't open the image itself.
nickcernis
force-pushed
the
nc/LOC-5969/local-9-compat
branch
from
ae678bf to
519a55e
Compare
bgturner
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@electron/remotefrom devDependencies to dependencies to ensure the add-on loads in Local 9. (An alternative to a larger refactoring to replace electron/remote with IPC calls, which I think is fair given the timeline and desired goal of making this work with Local 9.)For https://wpengine.atlassian.net/browse/LOC-5969.
Testing